Skip to content

[GFX-250] 钉 SHA 并只传必要 secret 修复 sonar-issues.yml 的 S7635/S7637 安全违规 - #234

Merged
AlianBlank merged 1 commit into
mainfrom
feature/gfx-250
Aug 6, 2026
Merged

AlianBlank merged 1 commit into
mainfrom
feature/gfx-250

Conversation

@AlianBlank

@AlianBlank AlianBlank commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Linear: GFX-250

Summary by CodeRabbit

  • Chores
    • 固定代码质量分析与同步工作流的版本,提升执行稳定性。
    • 优化凭据传递方式,仅显式传递必要的分析令牌。
    • 保持同步流程中的 Sonar 与 GitHub 参数不变。

@linear-code

linear-code Bot commented Aug 6, 2026

Copy link
Copy Markdown

GFX-250

@coderabbitai

coderabbitai Bot commented Aug 6, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@AlianBlank, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 38 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: a1a34f60-09f8-457d-b131-ad5ac7c40d5a

📥 Commits

Reviewing files that changed from the base of the PR and between 821a0af and d686d86.

📒 Files selected for processing (1)
  • .github/workflows/sonar-issues.yml
📝 Walkthrough

Walkthrough

Sonar 的 analyzesync 可复用工作流改用固定提交引用。工作流不再继承全部 secrets,而是显式传递 SONAR_TOKENsync 的 Sonar 和 GitHub 参数保持不变。

Changes

Sonar 工作流配置

Layer / File(s) Summary
固定工作流引用与显式密钥传递
.github/workflows/sonar-issues.yml
analyzesync 改用固定提交引用。两个工作流显式传递 SONAR_TOKEN,并保留 sync 的其他参数。

Estimated code review effort: 1 (Trivial) | ~5 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed 标题准确概括了固定 SHA、限制 secret 传递和修复 Sonar 安全违规这三个主要变更。
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/gfx-250

Comment @coderabbitai help to get the list of available commands.

@AlianBlank
AlianBlank merged commit 7cdfeaa into main Aug 6, 2026
1 check was pending
@AlianBlank
AlianBlank deleted the feature/gfx-250 branch August 6, 2026 05:56
@sonarqubecloud

sonarqubecloud Bot commented Aug 6, 2026

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant