Skip to content

[GFX-254] 抑制 UnicodeJsonEncoder 两个 unsafe override 的 Sonar S6640 告警 - #239

Merged
AlianBlank merged 1 commit into
mainfrom
feature/gfx-254
Aug 6, 2026
Merged

AlianBlank merged 1 commit into
mainfrom
feature/gfx-254

Conversation

@AlianBlank

Copy link
Copy Markdown
Contributor

Linear: GFX-254

FindFirstCharacterToEncode(char*,int) 与 TryEncodeUnicodeScalar(int,char*,int,out int) override 的是基类 System.Text.Encodings.Web.TextEncoder 的 abstract 成员,签名含 char*,unsafe 由 BCL 契约强制(删掉即 CS0214 编译错误)。按本仓既定范式(与 DsaHelper S4790 的 C61/C64/C65 一致)以方法级 [SuppressMessage] 抑制并写明 justification,承接 C56 搁置的'Json unsafe 无法回避'技术债;不改签名/行为/调用方,AllowUnsafeBlocks 编译开关保留。

Linear: GFX-254
@linear-code

linear-code Bot commented Aug 6, 2026

Copy link
Copy Markdown

GFX-254

@coderabbitai

coderabbitai Bot commented Aug 6, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@AlianBlank, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 32 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 4dcd6d90-60d7-4b26-92d5-d9ab5f821f1f

📥 Commits

Reviewing files that changed from the base of the PR and between bd51aec and 759f9b2.

📒 Files selected for processing (1)
  • GameFrameX.Foundation.Json/UnicodeJsonEncoder.cs

Comment @coderabbitai help to get the list of available commands.

@sonarqubecloud

sonarqubecloud Bot commented Aug 6, 2026

Copy link
Copy Markdown

@AlianBlank
AlianBlank merged commit 71a2df4 into main Aug 6, 2026
2 checks passed
@AlianBlank
AlianBlank deleted the feature/gfx-254 branch August 6, 2026 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant